Using proxy_params was too heavy handed #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default nginx proxy_params directives clobber the LB upstream HTTP_X_FORWARDED_PROTO header by setting it to $scheme. Instead, only set the Host header to overcome the implicit Host set by the proxy_pass directive, and rely on default behavior to pass on the remaining headers from the LB. Using $http_host rather than $host since the former is the client Host header and preserves the port number if present. Tested with local docker instance and behind LB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default nginx proxy_params directives clobber the LB upstream HTTP_X_FORWARDED_PROTO header by setting it to $scheme.
Instead, only set the Host header to overcome the implicit Host set by the proxy_pass directive, and rely on default behavior to pass on the remaining upstream headers from the LB.
Using $http_host rather than $host since the former is the client Host header and preserves the port number if present (tested to work both locally and behind LB).